Skip to content

refactor(@angular/build): convert metadata when using experimental chunk optimization #30806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 30, 2025

Refactors the chunk optimizer by introducing several helper functions to improve readability and maintainability. The rolldownToEsbuildMetafile function now converts rolldown output to an esbuild metafile, and the optimizeChunks function has been updated to use it. Additionally, helper functions have been created for generating initial file records and chunk optimization failure messages.

Closes #28830

@clydin clydin added the target: minor This PR is targeted for the next minor release label Jul 30, 2025
@clydin clydin force-pushed the chunk-optimizer/metadata branch from 817463c to dfa9f01 Compare July 30, 2025 22:04
…unk optimization

Refactors the chunk optimizer by introducing several helper functions to improve readability and
maintainability. The `rolldownToEsbuildMetafile` function now converts rolldown output to an esbuild metafile, and
the `optimizeChunks` function has been updated to use it. Additionally, helper functions have been created for
generating initial file records and chunk optimization failure messages.
@clydin clydin force-pushed the chunk-optimizer/metadata branch from dfa9f01 to d2138b2 Compare July 30, 2025 22:10
@clydin clydin marked this pull request as ready for review July 30, 2025 22:42
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 30, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 11, 2025
@alan-agius4 alan-agius4 merged commit 6d14e0c into angular:main Aug 11, 2025
31 of 32 checks passed
@clydin clydin deleted the chunk-optimizer/metadata branch August 11, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bundle meta when using NG_BUILD_OPTIMIZE_CHUNKS
2 participants